Demo Docs: Update the name of recommendation cache feature flag #4159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The name of the feature-flag for introducing the memory leak is actually `recommendationServiceCacheFailure`.
|
No worries. Before this gets merged, do you have any input on my comment about the feature flags when running in kube: open-telemetry/opentelemetry-demo#1343 (comment)? I'm happy to augment this PR with k8s-specific info if you think that would be helpful. It might also be helpful to harmonize on the flag names, since they are currently named differently in the json file (docker compose) vs the ffspostgres (k8s) |
cartermp
approved these changes
Mar 16, 2024
|
/fix:all |
|
You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/8308575573 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the demo docs to reference the correct name of the feature flag for the recommendation service cache failure. It's not a significant change but brings the docs in line with the flag name in the
demo.flagd.jsonfile.